-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check masquerade on instructor dashboard tab acess check #601
fix: check masquerade on instructor dashboard tab acess check #601
Conversation
7c816bb
to
7a1c242
Compare
Sandbox deploy request received. Deployment will start soon. |
Sandbox deployment started. |
7a1c242
to
251c959
Compare
251c959
to
88e54f9
Compare
88e54f9
to
5ce151c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the diff matches the upstream PR
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
Sandbox deployment successful. Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting |
Sandbox deployment started. |
Sandbox deployment successful. Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting |
Sandbox deployment started. |
Sandbox deployment successful. Sandbox LMS is available at pr-601-0e7f8a.staging.do.opencraft.hosting |
Sandbox update request received. Deployment will start soon. |
Backports openedx#33684.
Description
Check also masquerading role to determine if instructor tab is enabled, in order to hide it when a user with acess is masquerading as a student role without a specific different user.
Impacts Staff and Instructor users.
Testing instructions
Deadline
None
Other information
Private-Ref: https://tasks.opencraft.com/browse/BB-8087